Github user hsun-cnnxty commented on a diff in the pull request:
https://github.com/apache/storm/pull/705#discussion_r39595289
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/PartitionStateManagerFactory.java ---
@@ -0,0 +1,68 @@
+package storm.kafka;
+
+import backtype.storm.Config;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class PartitionStateManagerFactory {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(PartitionStateManagerFactory.class);
+
+ private ZkDataStore sharedZkDataStore;
+
+ private Map _stormConf;
+ private SpoutConfig _spoutConfig;
+
+
+ private ZkDataStore createZkDataStore(Map conf, SpoutConfig
spoutConfig) {
+ Map _zkDataStoreConf = new HashMap(conf);
+ List<String> zkServers = _spoutConfig.zkServers;
+ if (zkServers == null) {
+ zkServers = (List<String>)
conf.get(Config.STORM_ZOOKEEPER_SERVERS);
+ }
+ Integer zkPort = _spoutConfig.zkPort;
+ if (zkPort == null) {
+ zkPort = ((Number)
conf.get(Config.STORM_ZOOKEEPER_PORT)).intValue();
+ }
+ _zkDataStoreConf.put(Config.TRANSACTIONAL_ZOOKEEPER_SERVERS,
zkServers);
+ _zkDataStoreConf.put(Config.TRANSACTIONAL_ZOOKEEPER_PORT, zkPort);
+ _zkDataStoreConf.put(Config.TRANSACTIONAL_ZOOKEEPER_ROOT,
_spoutConfig.zkRoot);
+ return new ZkDataStore(_zkDataStoreConf);
+
+ }
+
+ public PartitionStateManagerFactory(Map stormConf, SpoutConfig
spoutConfig) {
+ this._stormConf = stormConf;
+ this._spoutConfig = spoutConfig;
+
+ // default to orignal storm storage format
+ if (_spoutConfig.stateStore == null ||
"storm".equals(_spoutConfig.stateStore)) {
+ sharedZkDataStore = createZkDataStore(_stormConf,
_spoutConfig);
+ }
+ }
+
+ public PartitionStateManager getInstance(Partition partition) {
+
+ if (_spoutConfig.stateStore == null ||
"storm".equals(_spoutConfig.stateStore)) {
+ return new
ZKBackedPartitionStateManager(_stormConf,_spoutConfig, partition,
sharedZkDataStore);
+
+ } else if ("kafka".equals(_spoutConfig.stateStore)) {
+ KafkaDataStore kafkaDataStore = new
KafkaDataStore(_stormConf, _spoutConfig, partition);
--- End diff --
The fix is pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
