Github user erikdw commented on the pull request:
https://github.com/apache/storm/pull/705#issuecomment-142121623
@hsun-cnnxty : I don't see the reference links in the Description on the
PR's Conversation view? Maybe I'm looking in the wrong place? Maybe they
should be in comments in the code too?
I'm guessing the following are the links you meant to put:
*
https://cwiki.apache.org/confluence/display/KAFKA/Committing+and+fetching+consumer+offsets+in+Kafka
*
https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol
I just want it to be very clear that this change is for changing from the
kafka spout's consumer offsets being stored in ZooKeeper, to instead being
stored directly in Kafka. We should also be clear about the version of Kafka
required for such support (0.8.2+). I know the current version of the
storm-kafka pom.xml (as of this change) is already referencing 0.8.2.1, but I
feel like it should be called out as an explicit requirement in the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
