[
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938786#comment-14938786
]
ASF GitHub Bot commented on STORM-1057:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r40845541
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -663,8 +673,9 @@
(reset! last-active true)
(log-message "Activating spout " component-id ":"
(keys task-datas))
(fast-list-iter [^ISpout spout spouts] (.activate
spout)))
-
- (fast-list-iter [^ISpout spout spouts] (.nextTuple
spout)))
+
+ (fast-list-iter [^ISpout spout spouts] (.nextTuple
spout))
--- End diff --
I'm not sure we want to split the ')' onto a new line. It does not follow
the formatting.
> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
> Key: STORM-1057
> URL: https://issues.apache.org/jira/browse/STORM-1057
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Li Wang
> Assignee: Li Wang
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance
> bottleneck of a topology. Displaying the throughputs of components and tasks
> on the web ui could greatly facilitate the user identifying the performance
> bottleneck and checking whether the the workload among components and tasks
> are balanced.
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
