[ 
https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938798#comment-14938798
 ] 

ASF GitHub Bot commented on STORM-1057:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/753#discussion_r40846293
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/RateTracker.java ---
    @@ -87,7 +95,7 @@ public final float reportRate() {
                 sum += _histograms[i];
             }
     
    -        return sum / (float) duration * 1000;
    --- End diff --
    
    Isn't the disruptor queue using RateTracker already?  Is this a bug in rate 
tracker where it said it was doing milliseconds but was really doing seconds?  
Or is this going to make the disruptor metrics wrong?


> Add throughput metric to spout/bolt and display them on web ui
> --------------------------------------------------------------
>
>                 Key: STORM-1057
>                 URL: https://issues.apache.org/jira/browse/STORM-1057
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Li Wang
>            Assignee: Li Wang
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Throughput is a fundamental metric to reasoning about the performance 
> bottleneck of a topology. Displaying the throughputs of components and tasks 
> on the web ui could greatly facilitate the user identifying the performance 
> bottleneck and checking whether the the workload among components and tasks 
> are balanced. 
> What to do:
> 1. Measure the throughput of each spout/bolt.
> 2. Display the throughput metrics on web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to