Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r40849246
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -570,7 +575,11 @@
(tasks-fn
out-stream-id values))
rooted? (and message-id
has-ackers?)
root-id (if rooted?
(MessageId/generateId rand))
- out-ids (fast-list-for [t
out-tasks] (if rooted? (MessageId/generateId rand)))]
+ out-ids (fast-list-for [t
out-tasks] (if rooted? (MessageId/generateId rand)))
+ sampler? (sampler)]
+ (when sampler?
+ (.notify rate-tracker (count
out-tasks))
+ (stats/update-stats-throughput!
(:stats executor-data) out-stream-id (.reportRate rate-tracker)))
--- End diff --
This is calculating the rate for the spout ignoring the stream-id, and then
storing it into the other stats saying it is for a specific stream id. That
does not work. Either we have to drop the stream-id from the reported stats or
we have to calculate it correctly per stream id.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
