Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/753#discussion_r40850076
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -570,7 +575,11 @@
(tasks-fn
out-stream-id values))
rooted? (and message-id
has-ackers?)
root-id (if rooted?
(MessageId/generateId rand))
- out-ids (fast-list-for [t
out-tasks] (if rooted? (MessageId/generateId rand)))]
+ out-ids (fast-list-for [t
out-tasks] (if rooted? (MessageId/generateId rand)))
+ sampler? (sampler)]
+ (when sampler?
+ (.notify rate-tracker (count
out-tasks))
--- End diff --
Wait I just thought about this again. How in the world can we get an
accurate rate if we are only counting a subset of the tuples? Wouldn't we also
have to increase the rate proportionally to the sampling rate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
