[
https://issues.apache.org/jira/browse/STORM-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941459#comment-14941459
]
ASF GitHub Bot commented on STORM-1086:
---------------------------------------
GitHub user kleinsch opened a pull request:
https://github.com/apache/storm/pull/779
STORM-1086. Make FailedMsgRetryManager configurable when setting up
KafkaSpout
We'd like to be able to drop messages when they've been replayed N times.
Seems easy to do if we could extend ExponentialBackoffMsgRetryManager, but
there's no way to inject a custom FailedMsgRetryManager without changing the
Kafka codebase. This PR allows users to inject the FailedMsgRetryManager when
creating a KafkaSpout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kleinsch/storm STORM-1086
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/779.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #779
----
commit dc58a8859a369b0e5e10120e60f2323ebdf5315c
Author: Nick Kleinschmidt <[email protected]>
Date: 2015-10-02T17:36:41Z
STORM-1086. Make FailedMsgRetryManager configurable when setting up
KafkaSpout
----
> Make FailedMsgRetryManager configurable when setting up KafkaSpout
> ------------------------------------------------------------------
>
> Key: STORM-1086
> URL: https://issues.apache.org/jira/browse/STORM-1086
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Reporter: Nick Kleinschmidt
> Assignee: Nick Kleinschmidt
> Priority: Minor
>
> The FailedMsgRetryManager interface makes replay behavior configurable and we
> default to using ExponentialBackoffMsgRetryManager, but there's no way to
> define your own FailedMsgRetryManager and plug it in when setting up
> KafkaSpout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
