[
https://issues.apache.org/jira/browse/STORM-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941709#comment-14941709
]
ASF GitHub Bot commented on STORM-1086:
---------------------------------------
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/780#discussion_r41064149
--- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java ---
@@ -39,6 +39,8 @@
public double retryDelayMultiplier = 1.0;
public long retryDelayMaxMs = 60 * 1000;
--- End diff --
Since the above values only apply to the ExponentialBackoff implementation,
it would be nice if we could factor them out of this class. They could probably
just be moved to `ExponentialBackoffMsgRetryManagerFactory`, and in that case
we could probably eliminate the factory pattern altogether.
> Make FailedMsgRetryManager configurable when setting up KafkaSpout
> ------------------------------------------------------------------
>
> Key: STORM-1086
> URL: https://issues.apache.org/jira/browse/STORM-1086
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Reporter: Nick Kleinschmidt
> Assignee: Nick Kleinschmidt
> Priority: Minor
>
> The FailedMsgRetryManager interface makes replay behavior configurable and we
> default to using ExponentialBackoffMsgRetryManager, but there's no way to
> define your own FailedMsgRetryManager and plug it in when setting up
> KafkaSpout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
