Github user choang commented on a diff in the pull request:
https://github.com/apache/storm/pull/705#discussion_r41323806
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -252,28 +253,26 @@ public void fail(Long offset) {
public void commit() {
long lastCompletedOffset = lastCompletedOffset();
if (_committedTo != lastCompletedOffset) {
- LOG.debug("Writing last completed offset (" +
lastCompletedOffset + ") to ZK for " + _partition + " for topology: " +
_topologyInstanceId);
+ LOG.debug("Writing last completed offset (" +
lastCompletedOffset + ") for " + _partition + " for topology: " +
_topologyInstanceId);
Map<Object, Object> data = (Map<Object, Object>)
ImmutableMap.builder()
- .put("topology", ImmutableMap.of("id",
_topologyInstanceId,
+ .put("topology", ImmutableMap.of(
--- End diff --
the auto formatting could be improved :( Probably not worth your time to
do this as I face the same issue, and fall back to my own formatting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
