Github user hsun-cnnxty commented on the pull request:
https://github.com/apache/storm/pull/705#issuecomment-147937919
@choang In recent changes, I have made it possible to plug in custom store
implementations. The custom implementation is given the opportunity to
initialize itself by injecting two configuration objects into the constructor
which takes the form like
public MyStoreImpl(Map conf, SpoutConfig spoutConfig)
In addition, I feel it is better to keep the implementation specific
details, such as zookeeper quorum, inside the store implementation instead of
leaving it to external class to build a implementation specific configuration
object such as KafkaStoreConfig. What do you think?
Thanks again for the code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
