Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549539
--- Diff:
storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java ---
@@ -248,8 +250,9 @@ public StormTopology buildTopology() {
}
private void markBatchGroups(String component, Map<String, String>
batchGroups) {
- for(String stream: batchGroups.keySet()) {
- _batchIds.put(new GlobalStreamId(component, stream),
batchGroups.get(stream));
+ for(Map.Entry<String, String> entry: batchGroups.entrySet()) {
+ String stream = entry.getKey();
+ _batchIds.put(new GlobalStreamId(component, stream),
entry.getValue());
--- End diff --
Unless the variable is created to make the code easier to read, this could
be simplified to
_batchIds.put(new GlobalStreamId(component, entry.getKey()),
entry.getValue());
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
