Github user sureshms commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43553925
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java ---
@@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf) {
kryoFactory.preRegister(k, conf);
boolean skipMissing = (Boolean)
conf.get(Config.TOPOLOGY_SKIP_MISSING_KRYO_REGISTRATIONS);
- for(String klassName: registrations.keySet()) {
- String serializerClassName = registrations.get(klassName);
+ for(Map.Entry<String, String> entry: registrations.entrySet()) {
+ String klassName = entry.getKey();
--- End diff --
There is another variable of type Class klass that is used in that part of
the code. So the name klassName is consistent with it. Any way the next version
of the patch just uses entry.getKey() directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
