Github user wuchong commented on the pull request:

    https://github.com/apache/storm/pull/885#issuecomment-157341386
  
    Looks good to me.
    
    But the condition code is a little reduplicate and verbose , I prefer to 
check only one variable to set streamId with reseting outputStreamId in 
SpoutConfig constructor.
    
    ```java
    this.outputStreamId = topicAsStreamId ? topic : this.outputStreamId;
    ```
    
    Not a big deal, just something trivial .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to