[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009767#comment-15009767
]
ASF GitHub Bot commented on STORM-876:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45134890
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -454,10 +455,82 @@
(shutdown-worker supervisor id))
))
+(defn get-blob-localname
+ "Given the blob information either gets the localname field if it exists,
+ else routines the default value passed in."
+ [blob-info defaultValue]
+ (if-let [val (if blob-info (get blob-info "localname") nil)] val
defaultValue))
+
+(defn should-uncompress-blob?
+ "Given the blob information returns the value of the uncompress field,
handling it either being
+ a string or a boolean value, or ifs its not specified then returns false"
+ [blob-info]
+ (boolean (and blob-info
+ (if-let [val (get blob-info "uncompress")]
+ (.booleanValue (Boolean. val))))))
--- End diff --
```Clojure
(Boolean. (get blob-info "uncompress"))
```
This should work for the cases we care about:
```
user=> (defn b [m k] (Boolean. (get m k)))
#'user/b
user=> (b nil "uncompress")
false
user=> (b {} "uncompress")
false
user=> (b {"uncompress" nil} "uncompress")
false
user=> (b {"uncompress" "false"} "uncompress")
false
user=> (b {"uncompress" "true"} "uncompress")
true
user=> (b {"uncompress" "TRUE"} "uncompress")
true
```
Also, in docstring `ifs its -> if it's`
> Dist Cache: Basic Functionality
> -------------------------------
>
> Key: STORM-876
> URL: https://issues.apache.org/jira/browse/STORM-876
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and
> downloading dist cache items. storm-core.ser, storm-conf.ser and storm.jar
> should be written into the blob store instead of residing locally. We need a
> default implementation of the blob store that does essentially what nimbus
> currently does and does not need anything extra. But having an HDFS backend
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and
> provide a working directory for the worker process with symlinks to the
> blobs. It should also allow the blobs to be updated and switch the symlink
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process
> of getting it ready to push back to open source shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
