[
https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011641#comment-15011641
]
ASF GitHub Bot commented on STORM-876:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r45241070
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -238,20 +241,21 @@
(defn- rmr-as-user
"Launches a process owned by the given user that deletes the given path
recursively. Throws RuntimeException if the directory is not removed."
- [conf id user path]
+ [conf id path]
+ (let [user (Utils/getFileOwner path)]
(worker-launcher-and-wait conf
user
["rmr" path]
:log-prefix (str "rmr " id))
(if (exists-file? path)
- (throw (RuntimeException. (str path " was not deleted")))))
+ (throw (RuntimeException. (str path " was not deleted"))))))
--- End diff --
Need to indent since we are adding the `let`. Removing the `user` param
was a good change here.
> Dist Cache: Basic Functionality
> -------------------------------
>
> Key: STORM-876
> URL: https://issues.apache.org/jira/browse/STORM-876
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: DISTCACHE.md, DistributedCacheDesignDocument.pdf
>
>
> Basic functionality for the Dist Cache feature.
> As part of this a new API should be added to support uploading and
> downloading dist cache items. storm-core.ser, storm-conf.ser and storm.jar
> should be written into the blob store instead of residing locally. We need a
> default implementation of the blob store that does essentially what nimbus
> currently does and does not need anything extra. But having an HDFS backend
> too would be great for scalability and HA.
> The supervisor should provide a way to download and manage these blobs and
> provide a working directory for the worker process with symlinks to the
> blobs. It should also allow the blobs to be updated and switch the symlink
> atomically to point to the new blob once it is downloaded.
> All of this is already done by code internal to Yahoo! we are in the process
> of getting it ready to push back to open source shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
