Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/838#discussion_r45511484
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/messaging/netty/ControlMessage.java ---
    @@ -57,14 +57,19 @@ int encodeLength() {
          * encode the current Control Message into a channel buffer
          * @throws Exception
          */
    -    ChannelBuffer buffer() throws IOException {
    +    public ChannelBuffer buffer() throws IOException {
    --- End diff --
    
    May as well fix the javadoc `@throws` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to