[ https://issues.apache.org/jira/browse/STORM-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088678#comment-15088678 ]
ASF GitHub Bot commented on STORM-1419: --------------------------------------- Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49157203 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -92,9 +108,17 @@ private void ack(Tuple tuple) throws SolrServerException, IOException { if (commitStgy == null) { collector.ack(tuple); } else { - toCommitTuples.add(tuple); - commitStgy.update(); - if (commitStgy.commit()) { + boolean forceCommit = false; + if (TupleUtils.isTick(tuple)) { + LOG.debug("TICK! forcing solr client commit"); + collector.ack(tuple); + forceCommit = true; + } else { + toCommitTuples.add(tuple); + commitStgy.update(); + } + + if (forceCommit || commitStgy.commit()) { --- End diff -- OK > Solr bolt should handle tick tuples > ----------------------------------- > > Key: STORM-1419 > URL: https://issues.apache.org/jira/browse/STORM-1419 > Project: Apache Storm > Issue Type: Bug > Components: storm-solr > Reporter: Xin Wang > Assignee: Xin Wang > > Solr bolt should handle tick tuples. > Forcing solr client commit when bolt received tick tuple. -- This message was sent by Atlassian JIRA (v6.3.4#6332)