[ https://issues.apache.org/jira/browse/STORM-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088764#comment-15088764 ]
ASF GitHub Bot commented on STORM-1419: --------------------------------------- Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49160913 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -131,6 +150,21 @@ private void failQueuedTuples(List<Tuple> failedTuples) { return queuedTuples; } + @Override + public Map<String, Object> getComponentConfiguration() { --- End diff -- @vesense I noticed that the body of this method is exactly the same for AbstractHdfsBolt. Furthermore, it's very likely that many Storm connector bolts will use the same code. Can you please write a helper method in TupleUtils and call that method here and AbstractHdfsBolt. > Solr bolt should handle tick tuples > ----------------------------------- > > Key: STORM-1419 > URL: https://issues.apache.org/jira/browse/STORM-1419 > Project: Apache Storm > Issue Type: Bug > Components: storm-solr > Reporter: Xin Wang > Assignee: Xin Wang > > Solr bolt should handle tick tuples. > Forcing solr client commit when bolt received tick tuple. -- This message was sent by Atlassian JIRA (v6.3.4#6332)