Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/728#discussion_r49227209
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslClientHandler.java
---
@@ -46,56 +44,48 @@ public KerberosSaslClientHandler(ISaslClient client,
Map storm_conf, String jaas
}
@Override
- public void channelConnected(ChannelHandlerContext ctx,
- ChannelStateEvent event) {
+ public void channelActive(ChannelHandlerContext ctx) throws Exception {
// register the newly established channel
- Channel channel = ctx.getChannel();
- client.channelConnected(channel);
+ Channel channel = ctx.channel();
+ client.channelReady();
LOG.info("Connection established from {} to {}",
- channel.getLocalAddress(), channel.getRemoteAddress());
+ channel.localAddress(), channel.localAddress());
--- End diff --
I don't think channel.getRemoteAddress and channel.localAddress return the
same thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
