Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/728#discussion_r49227426
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/messaging/netty/NettyUncaughtExceptionHandler.java
 ---
    @@ -21,6 +21,24 @@
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    +/*
    +public class StormClientErrorHandler extends ChannelInboundHandlerAdapter {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(StormClientErrorHandler.class);
    +    private String name;
    +
    +    StormClientErrorHandler(String name) {
    +        this.name = name;
    +    }
    +
    +    @Override
    +    public void exceptionCaught(ChannelHandlerContext ctx, Throwable 
cause) throws Exception {
    +        if (!(cause instanceof ConnectException)) {
    +            LOG.info("Connection failed " + name, cause);
    +        }
    +    }
    +}
    +*/
    +
    --- End diff --
    
    We should delete this commented out code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to