[ https://issues.apache.org/jira/browse/STORM-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090733#comment-15090733 ]
ASF GitHub Bot commented on STORM-1419: --------------------------------------- Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r49266446 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -59,16 +63,29 @@ public SolrUpdateBolt(SolrConfig solrConfig, SolrMapper solrMapper, SolrCommitSt this.solrConfig = solrConfig; this.solrMapper = solrMapper; this.commitStgy = commitStgy; - logger.debug("Created {} with the following configuration: " + + LOG.debug("Created {} with the following configuration: " + "[SolrConfig = {}], [SolrMapper = {}], [CommitStgy = {}]", this.getClass().getSimpleName(), solrConfig, solrMapper, commitStgy); } + @Override public void prepare(Map stormConf, TopologyContext context, OutputCollector collector) { this.collector = collector; this.solrClient = new CloudSolrClient(solrConfig.getZkHostString()); this.toCommitTuples = new ArrayList<>(capacity()); + this.tickTupleInterval = solrConfig.getTickTupleInterval(); --- End diff -- @vesense I would suggest that all the code handling the tickTupleInterval goes inside the method setTickTupleInterval. It is cleaner then setting the field tickTupleInterval in prepare, and then have an if, and then set the field again in setTickTupleInterval. The default case should be handled there as well. > Solr bolt should handle tick tuples > ----------------------------------- > > Key: STORM-1419 > URL: https://issues.apache.org/jira/browse/STORM-1419 > Project: Apache Storm > Issue Type: Bug > Components: storm-solr > Reporter: Xin Wang > Assignee: Xin Wang > > Solr bolt should handle tick tuples. > Forcing solr client commit when bolt received tick tuple. -- This message was sent by Atlassian JIRA (v6.3.4#6332)