Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1016#discussion_r49783662
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -701,11 +701,7 @@
;; making a map from node+port to WorkerSlot with
allocated resources
node+port->slot (into {} (for [[[node port]
[mem-on-heap mem-off-heap cpu]] worker->resources]
{[node port]
- (doto (WorkerSlot. node
port)
- (.allocateResource
- mem-on-heap
- mem-off-heap
- cpu))}))
+ (doto (WorkerSlot. node
port mem-on-heap mem-off-heap cpu))}))
--- End diff --
Can we remove the `doto` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
