Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1016#discussion_r49785320
--- Diff: storm-core/src/jvm/org/apache/storm/scheduler/WorkerSlot.java ---
@@ -40,11 +47,8 @@ public int getPort() {
return port;
}
- public WorkerSlot allocateResource(double memOnHeap, double
memOffHeap, double cpu) {
- this.memOnHeap += memOnHeap;
- this.memOffHeap += memOffHeap;
- this.cpu += cpu;
- return this;
+ public String getId() {
+ return this.getNodeId() + ":" + this.getPort();
--- End diff --
minor: Do not need `this.` when calling methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
