Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1016#discussion_r49787766
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -121,7 +116,7 @@ public SchedulingResult schedule(TopologyDetails td) {
td.getTaskResourceReqList(exec), entry.getKey() });
WorkerSlot targetSlot = this.findWorkerForExec(exec,
td, schedulerAssignmentMap);
if (targetSlot != null) {
- RAS_Node targetNode =
this.idToNode(targetSlot.getNodeId());
+ NodeDetails targetNode =
this.idToNode(targetSlot.getNodeId());
--- End diff --
It seems there is a chunk of duplicate code here and in the for loop below.
We are adding one line to both, but maybe it would be better to pull them out
into a helper method to avoid accidental mistakes in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
