[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134930#comment-15134930 ]
ASF GitHub Bot commented on STORM-1336: --------------------------------------- Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52069182 --- Diff: storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.storm.container; + +import java.util.Map; + +/** + * A plugin to support resource isolation and limitation within Storm + */ +public interface ResourceIsolationInterface { + + /** + * @param workerId worker id of the worker to start + * @param resources set of resources to limit + * @return a String that includes to command on how to start the worker. The string returned from this function + * will be concatenated to the front of the command to launch logwriter/worker in supervisor.clj + */ --- End diff -- minor: `The string returned`... Maybe we should describe that the string is a series of command line options for launching a JVM. It seems strange to document what the caller does with the string. > Evalute/Port JStorm cgroup support > ---------------------------------- > > Key: STORM-1336 > URL: https://issues.apache.org/jira/browse/STORM-1336 > Project: Apache Storm > Issue Type: New Feature > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: Boyang Jerry Peng > Labels: jstorm-merger > > Supports controlling the upper limit of CPU core usage for a worker using > cgroups > Sounds like a good start, will be nice to integrate it with RAS requests too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)