[ 
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134996#comment-15134996
 ] 

ASF GitHub Bot commented on STORM-1336:
---------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1053#discussion_r52072760
  
    --- Diff: conf/defaults.yaml ---
    @@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10
     pacemaker.childopts: "-Xmx1024m"
     pacemaker.auth.method: "NONE"
     pacemaker.kerberos.users: []
    +
    +storm.resource.isolation.plugin: 
"org.apache.storm.container.cgroup.CgroupManager"
    +
    +# Configs for CGroup support
    +storm.cgroup.hierarchy.dir: "/cgroup/storm_resources"
    +storm.cgroup.resources:
    +    - cpu
    +    - memory
    --- End diff --
    
    With few exceptions, I see string values are quoted. Not sure this would 
make a difference with these values, but maybe we should be consistent.


> Evalute/Port JStorm cgroup support
> ----------------------------------
>
>                 Key: STORM-1336
>                 URL: https://issues.apache.org/jira/browse/STORM-1336
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Boyang Jerry Peng
>              Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using 
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to