[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135025#comment-15135025
]
ASF GitHub Bot commented on STORM-1336:
---------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52074497
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystemType.java ---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup;
+
+public enum SubSystemType {
+
+ // net_cls,ns is not supposted in ubuntu
+ blkio, cpu, cpuacct, cpuset, devices, freezer, memory, perf_event,
net_cls, net_prio;
+
+ public static SubSystemType getSubSystem(String str) {
+ if (str.equals("blkio")) {
+ return blkio;
+ }
+ else if (str.equals("cpu")) {
+ return cpu;
+ }
+ else if (str.equals("cpuacct")) {
+ return cpuacct;
+ }
+ else if (str.equals("cpuset")) {
+ return cpuset;
+ }
+ else if (str.equals("devices")) {
+ return devices;
+ }
+ else if (str.equals("freezer")) {
+ return freezer;
+ }
+ else if (str.equals("memory")) {
+ return memory;
+ }
+ else if (str.equals("perf_event")) {
+ return perf_event;
+ }
+ else if (str.equals("net_cls")) {
+ return net_cls;
+ }
+ else if (str.equals("net_prio")) {
+ return net_prio;
+ }
--- End diff --
Can we rewrite this as a `switch` ?
> Evalute/Port JStorm cgroup support
> ----------------------------------
>
> Key: STORM-1336
> URL: https://issues.apache.org/jira/browse/STORM-1336
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
