[ 
https://issues.apache.org/jira/browse/STORM-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146378#comment-15146378
 ] 

ASF GitHub Bot commented on STORM-1245:
---------------------------------------

Github user bastiliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1069#discussion_r52837863
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/acker.clj ---
    @@ -18,74 +18,24 @@
       (:import [org.apache.storm.tuple Tuple Fields])
    --- End diff --
    
    In clojure testing, creation of acker bolt will be overridden in 
with-tracked-cluster. After porting the implementation of acker to java, it 
seems there is no way to do a similar override for java method. So, the 
mk-acker-bolt of acker.clj was kept as temporary solution to make the clojure 
testing pass. It can be removed after the porting of common.clj and relative 
testing modules. Is there a solution or workaround for this issue?


> port backtype.storm.daemon.acker to java
> ----------------------------------------
>
>                 Key: STORM-1245
>                 URL: https://issues.apache.org/jira/browse/STORM-1245
>             Project: Apache Storm
>          Issue Type: New Feature
>            Reporter: Robert Joseph Evans
>            Assignee: Basti Liu
>              Labels: java-migration, jstorm-merger
>
> use 
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task/acker/Acker.java
>  as a guide



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to