[ 
https://issues.apache.org/jira/browse/STORM-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149072#comment-15149072
 ] 

ASF GitHub Bot commented on STORM-1245:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1069#discussion_r53057252
  
    --- Diff: storm-core/src/jvm/org/apache/storm/daemon/AckerBolt.java ---
    @@ -0,0 +1,128 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.daemon;
    +
    +import org.apache.storm.task.IBolt;
    +import org.apache.storm.task.OutputCollector;
    +import org.apache.storm.task.TopologyContext;
    +import org.apache.storm.tuple.Tuple;
    +import org.apache.storm.utils.RotatingMap;
    +import org.apache.storm.utils.TupleUtils;
    +import org.apache.storm.utils.Utils;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +public class AckerBolt implements IBolt {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(AckerBolt.class);
    +
    +    private static final long serialVersionUID = 4430906880683183091L;
    +
    +    public static final String ACKER_COMPONENT_ID = "__acker";
    +    public static final String ACKER_INIT_STREAM_ID = "__ack_init";
    +    public static final String ACKER_ACK_STREAM_ID = "__ack_ack";
    +    public static final String ACKER_FAIL_STREAM_ID = "__ack_fail";
    +
    +    public static final int TIMEOUT_BUCKET_NUM = 3;
    --- End diff --
    
    Sounds good.


> port backtype.storm.daemon.acker to java
> ----------------------------------------
>
>                 Key: STORM-1245
>                 URL: https://issues.apache.org/jira/browse/STORM-1245
>             Project: Apache Storm
>          Issue Type: New Feature
>            Reporter: Robert Joseph Evans
>            Assignee: Basti Liu
>              Labels: java-migration, jstorm-merger
>
> use 
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task/acker/Acker.java
>  as a guide



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to