Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-189004616
I agree that we need to keep track of outstanding tuples + offsets, and the
code you have around acked feels OK, but we could possibly clean it up a
little. I called it markAsDone instead of addAckedTuples because I didn't
really like having a tuple that failed too many times be marked as acked, but
thinking about it more it is not that big of a deal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
