Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/1141#issuecomment-189154415
  
    @haohui In some cases like `true AND null` the query was still returning 
results, hence I had changed `StormSqlFunctions.eq` and `StormSqlFunctions.ne` 
to return false if either arg was null. The actual issue was in AND_EXPR and 
OR_EXPR, so I fixed it and reverted the earlier change. I have also split the 
change into two commits to review easily. 
    
    Currently the UDF schema definition is not exposed via SQL CREATE. Let me 
know if you have any inputs on how this could be done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to