Github user haohui commented on the pull request:
https://github.com/apache/storm/pull/1141#issuecomment-189522481
Thanks for updating the patch!
> In some cases like true AND null the query was still returning results,
hence I had changed StormSqlFunctions.eq and StormSqlFunctions.ne to return
false if either arg was null.
That sounds like a bug to me. Can you please create a jira and post the
query?
Posted inlined comment. I think the first commit is pretty good. Let's
separate the second commit to another jira.
There are some pending tasks. I think we need to expose array / UDF in the
DDL as well, my suggestion is to closely follow the syntax of Hive. I think
both work can be done in separate jiras.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
