[ 
https://issues.apache.org/jira/browse/STORM-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168623#comment-15168623
 ] 

ASF GitHub Bot commented on STORM-1570:
---------------------------------------

Github user arunmahadevan commented on the pull request:

    https://github.com/apache/storm/pull/1141#issuecomment-189154415
  
    @haohui In some cases like `true AND null` the query was still returning 
results, hence I had changed `StormSqlFunctions.eq` and `StormSqlFunctions.ne` 
to return false if either arg was null. The actual issue was in AND_EXPR and 
OR_EXPR, so I fixed it and reverted the earlier change. I have also split the 
change into two commits to review easily. 
    
    Currently the UDF schema definition is not exposed via SQL CREATE. Let me 
know if you have any inputs on how this could be done.


> Support nested field lookup and user defined functions in Storm sql
> -------------------------------------------------------------------
>
>                 Key: STORM-1570
>                 URL: https://issues.apache.org/jira/browse/STORM-1570
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to