[ 
https://issues.apache.org/jira/browse/STORM-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170073#comment-15170073
 ] 

ASF GitHub Bot commented on STORM-1570:
---------------------------------------

Github user haohui commented on the pull request:

    https://github.com/apache/storm/pull/1141#issuecomment-189522481
  
    Thanks for updating the patch!
    
    > In some cases like true AND null the query was still returning results, 
hence I had changed StormSqlFunctions.eq and StormSqlFunctions.ne to return 
false if either arg was null. 
    
    That sounds like a bug to me. Can you please create a jira and post the 
query?
    
    Posted inlined comment. I think the first commit is pretty good. Let's 
separate the second commit to another jira.
    
    There are some pending tasks. I think we need to expose array / UDF in the 
DDL as well, my suggestion is to closely follow the syntax of Hive. I think 
both work can be done in separate jiras.


> Support nested field lookup and user defined functions in Storm sql
> -------------------------------------------------------------------
>
>                 Key: STORM-1570
>                 URL: https://issues.apache.org/jira/browse/STORM-1570
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to