[ 
https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169093#comment-15169093
 ] 

ASF GitHub Bot commented on STORM-1252:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1147#discussion_r54249653
  
    --- Diff: storm-core/src/jvm/org/apache/storm/stats/BoltExecutorStats.java 
---
    @@ -0,0 +1,107 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.stats;
    +
    +import clojure.lang.PersistentVector;
    +import java.util.HashMap;
    +import java.util.Map;
    +import org.apache.storm.metric.internal.MultiCountStatAndMetric;
    +import org.apache.storm.metric.internal.MultiLatencyStatAndMetric;
    +
    +@SuppressWarnings("unchecked")
    +public class BoltExecutorStats extends CommonStats {
    +
    +    public static final String ACKED = "acked";
    +    public static final String FAILED = "failed";
    +    public static final String EXECUTED = "executed";
    +    public static final String PROCESS_LATENCIES = "process-latencies";
    +    public static final String EXECUTE_LATENCIES = "execute-latencies";
    +
    +    public static final String[] BOLT_FIELDS = {ACKED, FAILED, EXECUTED, 
PROCESS_LATENCIES, EXECUTE_LATENCIES};
    +
    +    public BoltExecutorStats() {
    +        super();
    +
    +        put(ACKED, new MultiCountStatAndMetric(NUM_STAT_BUCKETS));
    +        put(FAILED, new MultiCountStatAndMetric(NUM_STAT_BUCKETS));
    +        put(EXECUTED, new MultiCountStatAndMetric(NUM_STAT_BUCKETS));
    +        put(PROCESS_LATENCIES, new 
MultiLatencyStatAndMetric(NUM_STAT_BUCKETS));
    +        put(EXECUTE_LATENCIES, new 
MultiLatencyStatAndMetric(NUM_STAT_BUCKETS));
    +    }
    +
    +    public MultiCountStatAndMetric getAcked() {
    +        return (MultiCountStatAndMetric) this.get(ACKED);
    +    }
    +
    +    public MultiCountStatAndMetric getFailed() {
    +        return (MultiCountStatAndMetric) this.get(FAILED);
    +    }
    +
    +    public MultiCountStatAndMetric getExecuted() {
    +        return (MultiCountStatAndMetric) this.get(EXECUTED);
    +    }
    +
    +    public MultiLatencyStatAndMetric getProcessLatencies() {
    +        return (MultiLatencyStatAndMetric) this.get(PROCESS_LATENCIES);
    +    }
    +
    +    public MultiLatencyStatAndMetric getExecuteLatencies() {
    +        return (MultiLatencyStatAndMetric) this.get(EXECUTE_LATENCIES);
    +    }
    +
    +    public void boltExecuteTuple(String component, String stream, long 
latencyMs) {
    +        Object key = PersistentVector.create(component, stream);
    --- End diff --
    
    In this case we can probably just create a new List and use that as the 
key.  Any List will probably do.


> port backtype.storm.stats to java
> ---------------------------------
>
>                 Key: STORM-1252
>                 URL: https://issues.apache.org/jira/browse/STORM-1252
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Cody
>              Labels: java-migration, jstorm-merger
>
> clojure methods for getting/setting built-in statistics.  Mostly wrappers 
> around some java classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to