[ https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169127#comment-15169127 ]
ASF GitHub Bot commented on STORM-1252: --------------------------------------- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1147#discussion_r54251465 --- Diff: storm-core/src/jvm/org/apache/storm/stats/CommonStats.java --- @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.stats; + +import java.util.HashMap; +import java.util.Map; +import org.apache.storm.metric.api.IMetric; +import org.apache.storm.metric.internal.MultiCountStatAndMetric; +import org.apache.storm.metric.internal.MultiLatencyStatAndMetric; + +@SuppressWarnings("unchecked") +public class CommonStats { + public static final int NUM_STAT_BUCKETS = 20; + + public static final String RATE = "rate"; + + public static final String EMITTED = "emitted"; + public static final String TRANSFERRED = "transferred"; + public static final String[] COMMON_FIELDS = {EMITTED, TRANSFERRED}; + + protected int rate; --- End diff -- I would prefer this to be a final int and set in the constructor. Changing it in the middle of operation would require a coordinated effort with external code that does the sampling. > port backtype.storm.stats to java > --------------------------------- > > Key: STORM-1252 > URL: https://issues.apache.org/jira/browse/STORM-1252 > Project: Apache Storm > Issue Type: New Feature > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: Cody > Labels: java-migration, jstorm-merger > > clojure methods for getting/setting built-in statistics. Mostly wrappers > around some java classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)