[
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176334#comment-15176334
]
ASF GitHub Bot commented on STORM-822:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1131#discussion_r54779292
--- Diff:
external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutStream.java
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.kafka.spout;
+
+import org.apache.storm.tuple.Fields;
+import org.apache.storm.utils.Utils;
+
+import java.io.Serializable;
+
+public class KafkaSpoutStream implements Serializable {
+ public static final String DEFAULT_TOPIC =
"DEFAULT_TOPIC_KAFKA_SPOUT_INTERNAL";
+ private final Fields outputFields;
+ private final String streamId;
+ private final String topic;
+
+ /** Declare specified outputFields with default stream and default
topic */
+ public KafkaSpoutStream(Fields outputFields) {
+ this(outputFields, Utils.DEFAULT_STREAM_ID);
+ }
+
+ /** Declare specified outputFields with specified stream and default
topic */
+ public KafkaSpoutStream(Fields outputFields, String streamId) {
+ this(outputFields, streamId, DEFAULT_TOPIC);
+ }
+
+ /** Declare specified outputFields with specified stream and specified
topic */
+ public KafkaSpoutStream(Fields outputFields, String streamId, String
topic) {
--- End diff --
I am a bit confused by having both KafkaSpoutStream(s) and
KafkaSpoutConfig.topics.
It feels like they really should be together in one user facing API,
especially if we want to support a Pattern topic in the future. Perhaps
something that would let me do something like the following in the
KafkaSpoutConfig.Builder
```
public Builder addTopics(String... topics, Fields outputFileds);
```
> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to
> reduce dependencies and use long term supported kafka apis
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-822
> URL: https://issues.apache.org/jira/browse/STORM-822
> Project: Apache Storm
> Issue Type: Story
> Components: storm-kafka
> Reporter: Thomas Becker
> Assignee: Hugo Louro
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
