[ 
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182889#comment-15182889
 ] 

ASF GitHub Bot commented on STORM-822:
--------------------------------------

Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1131#discussion_r55190400
  
    --- Diff: pom.xml ---
    @@ -836,14 +839,39 @@
                     <scope>test</scope>
                 </dependency>
                 <dependency>
    -              <groupId>org.apache.calcite</groupId>
    -              <artifactId>calcite-core</artifactId>
    -              <version>${calcite.version}</version>
    +                <groupId>org.apache.calcite</groupId>
    +                <artifactId>calcite-core</artifactId>
    +                <version>${calcite.version}</version>
    +            </dependency>
    +            <dependency>
    +                <groupId>com.fasterxml.jackson.core</groupId>
    +                <artifactId>jackson-databind</artifactId>
    +                <version>${jackson.version}</version>
    +            </dependency>
    +            <dependency>
    +                <groupId>org.apache.kafka</groupId>
    +                <artifactId>${kafka.artifact.id}</artifactId>
    +                <version>${kafka.version}</version>
    +                <exclusions>
    +                    <exclusion>
    +                        <groupId>org.apache.zookeeper</groupId>
    +                        <artifactId>zookeeper</artifactId>
    +                    </exclusion>
    +                    <exclusion>
    +                        <groupId>log4j</groupId>
    +                        <artifactId>log4j</artifactId>
    +                    </exclusion>
    +                    <exclusion>
    +                        <groupId>org.slf4j</groupId>
    +                        <artifactId>slf4j-log4j12</artifactId>
    +                    </exclusion>
    +                </exclusions>
                 </dependency>
                 <dependency>
    -              <groupId>com.fasterxml.jackson.core</groupId>
    -              <artifactId>jackson-databind</artifactId>
    -              <version>${jackson.version}</version>
    +                <groupId>org.apache.kafka</groupId>
    +                <artifactId>kafka-clients</artifactId>
    +                <version>${kafka.version}</version>
    +                <scope>provided</scope>
    --- End diff --
    
    @revans2 I left the provided unchanged with my last changes, and will take 
care of fixing all of this when I submit a patch for STORM-1599.


> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to 
> reduce dependencies and use long term supported kafka apis 
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-822
>                 URL: https://issues.apache.org/jira/browse/STORM-822
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-kafka
>            Reporter: Thomas Becker
>            Assignee: Hugo Louro
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to