[
https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190502#comment-15190502
]
ASF GitHub Bot commented on STORM-1616:
---------------------------------------
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55792475
--- Diff: storm-core/src/jvm/org/apache/storm/trident/Stream.java ---
@@ -124,6 +124,31 @@ public Stream parallelismHint(int hint) {
}
/**
+ * Sets the CPU Load resource for the current node
+ */
+ public Stream setCPULoad(Number load) {
--- End diff --
> I can look at adding a method for including a component -> resources map
when creating a trident topology.
It would be best if we could have these settings as a part of the topology
than the stream.
> I may be missing the benefit here, but as far as I can tell, it doesn't
read any cleaner for users, The Stream api would have only this one extra
non-stream-operation method. E.g. when the user browses the javadocs or when
the IDE pops up the methods of the stream.
>and IMO, users shouldn't really need to be aware of Nodes at all. They're
supposed to be internal to Trident.
Yes, its ideal if its part of the topology configuration. In my opinion if
we are exposing config via the stream api, its better to let it standout than
attempting to hide it in with the other streaming operations because the user
needs to be aware of what he is doing. `nodeConfig` was only a suggestion, it
could be named appropriately.
> Add RAS API for Trident
> -----------------------
>
> Key: STORM-1616
> URL: https://issues.apache.org/jira/browse/STORM-1616
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Kyle Nusbaum
> Assignee: Kyle Nusbaum
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
