[
https://issues.apache.org/jira/browse/STORM-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191183#comment-15191183
]
ASF GitHub Bot commented on STORM-1616:
---------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55854466
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -394,11 +395,28 @@ public StormTopology build() {
Map<Node, String> spoutIds = genSpoutIds(spoutNodes);
Map<Group, String> boltIds = genBoltIds(mergedGroups);
+ Map defaults = Utils.readDefaultConfig();
+
for(SpoutNode sn: spoutNodes) {
Integer parallelism = parallelisms.get(grouper.nodeGroup(sn));
+
+ Map<String, Number> spoutRes = null;
+ if(sn instanceof ITridentResource) {
+ spoutRes =
mergeDefaultResources(((ITridentResource)sn).getResources(), defaults);
+ }
+ else {
+ spoutRes = mergeDefaultResources(null, defaults);
+ }
--- End diff --
Good catch. I think we can ignore the null check even, though. We don't
insert nulls into the spoutNodes collection, and if there were some in there
somehow, lots of stuff would blow up.
> Add RAS API for Trident
> -----------------------
>
> Key: STORM-1616
> URL: https://issues.apache.org/jira/browse/STORM-1616
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Kyle Nusbaum
> Assignee: Kyle Nusbaum
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
