Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57174134
--- Diff: storm-core/src/clj/org/apache/storm/config.clj ---
@@ -53,7 +54,7 @@
[freq]
(let [freq (int freq)
start (int 0)
- r (java.util.Random.)
+ r (XORShiftRandom.)
--- End diff --
Here too the code can be called from multiple threads, but the worst that
happens is we double up on sampling some items for metrics. Ideally this would
have a comment explaining this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
