[
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211366#comment-15211366
]
ASF GitHub Bot commented on STORM-1632:
---------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-201122231
Just to update, here's my numbers.
```
> -c topology.eventlogger.executors=0 -c topology.max.spout.pending=2000 -c
topology.disruptor.batch.size=10000
10m 0s 1001252900 500626839 0.000 500626428
10m 0s 1031746043 515873225 0.000 515872910
> -c topology.eventlogger.executors=1 -c topology.max.spout.pending=2000 -c
topology.disruptor.batch.size=10000
10m 0s 933932980 466965808 0.000 466965793
10m 0s 922674155 461337280 0.000 461337282
----
> -c topology.eventlogger.executors=0 -c topology.max.spout.pending=2000 -c
topology.disruptor.batch.size=10000 -c topology.workers=2
10m 0s 985430460 492607760 0.000 492607800
10m 0s 1012353360 506175040 0.000 506175060
> -c topology.eventlogger.executors=1 -c topology.max.spout.pending=2000 -c
topology.disruptor.batch.size=10000 -c topology.workers=2
10m 0s 945182034 472570221 0.000 472570221
10m 0s 919781311 459891331 0.000 459891312
```
Performance hit is shown, and it seems that it even affects spout and bolt
are running in different workers.
Since I ran test with my local machine so it could be flaky. Anyway it
seems clear that there's performance hit.
If we can test it into multiple machines that would be good.
**But anyway, I really don't want to drag releasing 1.0.0 so we want to
keep it as is in 1.0.0, I'm OK.**
No need to vote -1 to this PR but let's change priority on issue to
'Critical' or even 'Major', and remove Epic link.
There're some issues still open with Epic, so we may have to move to
resolve them ASAP.
> Disable event logging by default
> --------------------------------
>
> Key: STORM-1632
> URL: https://issues.apache.org/jira/browse/STORM-1632
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Priority: Blocker
> Fix For: 1.0.0
>
> Attachments: BasicTopology.java
>
>
> EventLogging has performance penalty. For a simple speed of light topology
> with a single instances of a spout and a bolt, disabling event logging
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off
> by default.
> **Update:** with acker=0 the observed impact was much higher... **25%**
> faster when event loggers = 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
