[ 
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212826#comment-15212826
 ] 

ASF GitHub Bot commented on STORM-1632:
---------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/1217#issuecomment-201709299
  
    I guess @arunmahadevan removes not only instantiation of Long but also 
Random.randInt() which makes sense to me.
    
    @roshannaik @arunmahadevan 
    Btw, please change your BasicTopology to here,
    
    - Roshan's: https://gist.github.com/HeartSaVioR/9fd277307d4d5efcd47f
    - Arun's: https://gist.github.com/HeartSaVioR/0e2555633a5f7d12cb68
    
    I pasted functionality about printing metrics from cluster information 
periodically. (It came from FastWordCountTopology.)
    Why this change is necessary is because I saw the behavior that throughput 
of topology from Roshan isn't be consistent even after 10 mins (it's 
increasing), so when exactly you refreshed UI can change your numbers. (Please 
note that 10m is changed, too)
    
    You may want to increase your benchmark period long enough (by modifying 
loop count in main) to see when its speed becomes stabilized. You may also want 
to make period as argument.


> Disable event logging by default
> --------------------------------
>
>                 Key: STORM-1632
>                 URL: https://issues.apache.org/jira/browse/STORM-1632
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Roshan Naik
>            Assignee: Roshan Naik
>            Priority: Blocker
>         Attachments: BasicTopology.java
>
>
> EventLogging has performance penalty. For a simple speed of light topology  
> with a single instances of a spout and a bolt, disabling event logging 
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off 
> by default.
> **Update:** with acker=0  the observed impact was much higher... **25%** 
> faster when event loggers = 0 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to