Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-201568283
@harshach @revans2 @abhishekagarwal87 I believe the current implementation
addressed everything that we discussed. Can you please take a look and give
some feedback.
The changes to not keep ConsumerRecords state inside the Spout are in a new
commit such that you can compare the two and have the flexibility to merge the
initial commit (thoroughly reviewed) first, if one wants to do so.
@abhishekagarwal87 I thought about this thoroughly and my conclusion is
that `OutputFields` are are associated with `Streams` and the logic to `build
tuples` is associated with `topics`. The current implementation supports
multiple topics emitting to the same stream, whereas the previous KafkaSpout
didn't. The logic to build tuples is related, but independent from the
`OutputFields'. That is because we may declare 10 `OutputFields` but yet for
particular topic we may wish to build tuples with only one `Field`. My current
implementation follows this approach.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
