[
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212550#comment-15212550
]
ASF GitHub Bot commented on STORM-822:
--------------------------------------
Github user hmcl commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-201568283
@harshach @revans2 @abhishekagarwal87 I believe the current implementation
addressed everything that we discussed. Can you please take a look and give
some feedback.
The changes to not keep ConsumerRecords state inside the Spout are in a new
commit such that you can compare the two and have the flexibility to merge the
initial commit (thoroughly reviewed) first, if one wants to do so.
@abhishekagarwal87 I thought about this thoroughly and my conclusion is
that `OutputFields` are are associated with `Streams` and the logic to `build
tuples` is associated with `topics`. The current implementation supports
multiple topics emitting to the same stream, whereas the previous KafkaSpout
didn't. The logic to build tuples is related, but independent from the
`OutputFields'. That is because we may declare 10 `OutputFields` but yet for
particular topic we may wish to build tuples with only one `Field`. My current
implementation follows this approach.
Thanks!
> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to
> reduce dependencies and use long term supported kafka apis
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-822
> URL: https://issues.apache.org/jira/browse/STORM-822
> Project: Apache Storm
> Issue Type: Story
> Components: storm-kafka
> Reporter: Thomas Becker
> Assignee: Hugo Louro
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
