[
https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219500#comment-15219500
]
ASF GitHub Bot commented on STORM-1632:
---------------------------------------
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1217#issuecomment-203792662
1 . The tooltip takes some time to show up, whereas the tooltip on other
elements like the title elements under Topology summary shows up immediately. I
played around a bit and found a way to show the tooltip on disabled button
immediately using the same style as other tooltips. You need to wrap the input
element in a span like below,
```javascript
<span style="display:inline-block;" data-toggle="tooltip" title=""
data-original-title="To debug set topology.eventlogger.executors to a value > 0
or nil">
<input disabled="" onclick="confirmAction('test-topology-1-1459402415',
'test-topology', 'debug/enable', true, 10, 'sampling percentage', 'debug')"
type="button" value="Debug" class="btn btn-default">
</span>
```
2 . The tooltip is shown even if the button is enabled. You could add the
`<span> </span>` only when number of executors is 0, which would take care of
this.
3 . The tooltip is also shown when the debug button gets disabled after the
user clicks on it (when topology.eventlogger.executors > 0). Similar fix as
above.
4 . The button should be disabled in the spout/bolt pages as well.
> Disable event logging by default
> --------------------------------
>
> Key: STORM-1632
> URL: https://issues.apache.org/jira/browse/STORM-1632
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Priority: Blocker
> Attachments: BasicTopology.java
>
>
> EventLogging has performance penalty. For a simple speed of light topology
> with a single instances of a spout and a bolt, disabling event logging
> delivers a 7% to 9% perf improvement (with acker count =1)
> Event logging can be enabled when there is need to do debug, but turned off
> by default.
> **Update:** with acker=0 the observed impact was much higher... **25%**
> faster when event loggers = 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
