Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1451#discussion_r65303547
  
    --- Diff: 
external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java ---
    @@ -188,6 +189,47 @@ public void declareOutputFields(OutputFieldsDeclarer 
declarer) {
             }
         }
     
    +    @Override
    +    public Map<String, Object> getComponentConfiguration () {
    --- End diff --
    
    looks to be quite a bit of logic in here. If it makes sense lets move most 
of it into KafkaUtils.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to