Github user priyank5485 commented on the issue:

    https://github.com/apache/storm/pull/1451
  
    @harshach I have renamed Kafka Log Head Offset to Latest Offset, since 
Kafka is present in ui header and topic is a column already. I have also 
renamed the Query classes as per your suggestion.
    
    Regarding moving it under package tool, I thought of this module specific 
to kafka and getting the offset lags. If you are okay with it we can keep it as 
is instead of creating a tools package. Or any other suggestion if you have.
    
    Regarding moving getComponentConfiguration to KafkaUtils, KafkaUtils exist 
only in the old module. So i will keep it in the spout for now. I plan to add 
getComponentConfiguration for trident as well. If there is code duplication 
there, I will try to reuse it for old module and new module(when trident is 
ready).
    
    Let me know if there is anything else you want me to address. Otherwise I 
will squash the commits


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to