Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1474#discussion_r66339711
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -72,8 +72,10 @@
private transient boolean initialized; //
Flag indicating that the spout is still undergoing initialization process.
// Initialization is only complete after the first call to
KafkaSpoutConsumerRebalanceListener.onPartitionsAssigned()
+ private KafkaSpoutStream kafkaSpoutStream;
private KafkaSpoutStreams kafkaSpoutStreams; //
Object that wraps all the logic to declare output fields and emit tuples
private transient KafkaSpoutTuplesBuilder<K, V> tuplesBuilder; //
Object that contains the logic to build tuples for each ConsumerRecord
+ private transient KafkaSpoutTupleBuilder<K, V> tupleBuilder;
--- End diff --
can't we just tuplesBuilder for this . Any reason to have another
tupleBuilder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
