[ 
https://issues.apache.org/jira/browse/STORM-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364658#comment-15364658
 ] 

ASF GitHub Bot commented on STORM-1916:
---------------------------------------

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1507#discussion_r69772245
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -2104,6 +2109,17 @@ public String addToClasspathImpl(String classpath,
             return StringUtils.join(l, CLASS_PATH_SEPARATOR);
         }
     
    +    public String addToClasspathImpl(Collection<String> classpath,
    +                Collection<String> paths) {
    +        String basePath = StringUtils.join(classpath, 
CLASS_PATH_SEPARATOR);
    --- End diff --
    
    I think the implementation can be simpler.
    ```
    List<String> allPaths = new ArrayList<>();
    allPaths.addAll(classPaths)
    allPaths.addAll(paths);
    return StringUtils.join(allPaths, CLASS_PATH_SEPARATOR);


> Add ability for worker-first classpath
> --------------------------------------
>
>                 Key: STORM-1916
>                 URL: https://issues.apache.org/jira/browse/STORM-1916
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>
> Debugging in multi-tenant environments can be difficult, and having the 
> ability to override the classpath can be helpful. We want a topology config 
> that specifies an overriding classpath for a given topology. This config is 
> disabled by default since users overriding the classpath is dangerous in a 
> multi-tenant environment. The config can be temporarily enabled on Nimbus to 
> allow submission of topologies with overridden classpaths. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to